Re: [PATCH 16/16] perf, persistent: Allow multiple users for an event

[Borislav Petkov]

On Tue, Jun 04, 2013 at 11:19:21AM +0200, Jiri Olsa wrote:
> hum, can't see it:
> 
> perf SYSCALL:
> ...
> 	return perf_get_persistent_event_fd(cpu, &attr);
> 
> ...
> int perf_get_persistent_event_fd(unsigned cpu, struct perf_event_attr *attr)
> {
>         struct pers_event_desc *desc;
>         struct perf_event *event;
>         int event_fd = -ENODEV;
> 
>         mutex_lock(&per_cpu(pers_events_lock, cpu));
> ...
> 
> 'cpu' did not pass ay check here..

Oh, I see.

You mean something like

	if (cpu < NR_CPUS && cpu_online(cpu))

?

I guess that should cover your concerns...

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/