Re: [PATCH] TTY:vt: convert remain take_over_console's users todo_take_over_console

[Pavel Machek]

On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> Impact:
> 1:convert all remain take_over_console to do_take_over_console

This is step backwards.

> --- a/arch/alpha/kernel/console.c
> +++ b/arch/alpha/kernel/console.c
> @@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
>  
>  	/* Set the VGA hose and init the new console. */
>  	pci_vga_hose = hose;
> -	take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> +	console_lock();
> +	do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> +	console_unlock();
>  }

Original was better.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/