RE: [hv] BUG: kernel freezes after [ 13.356381] PCI: CLS 0 bytes,default 64

From: KY Srinivasan
Date: Tue Jun 04 2013 - 19:37:05 EST




> -----Original Message-----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> Sent: Tuesday, June 04, 2013 6:44 PM
> To: Fengguang Wu
> Cc: KY Srinivasan; devel@xxxxxxxxxxxxxxxxxxxxxx; Greg Kroah-Hartman; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [hv] BUG: kernel freezes after [ 13.356381] PCI: CLS 0 bytes, default
> 64
>
> On Tue, Jun 04, 2013 at 10:15:36PM +0800, Fengguang Wu wrote:
> > Greetings,
> >
> > I got the below dmesg (kernel freezes at the end of it) and the first bad commit
> is
> >
> > commit cf6a2eacbcb2593b5b91d0817915c4f0464bb534
> > Author: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > Date: Thu Dec 1 09:59:34 2011 -0800
> >
> > drivers: hv: Don't OOPS when you cannot init vmbus
> >
> > The hv vmbus driver was causing an OOPS since it was trying to register
> drivers
> > on top of the bus even if initialization of the bus has failed for some
> > reason (such as the odd chance someone would run a hv enabled kernel in a
> > non-hv environment).
> >
> > Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx>
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > Cc: stable <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > [ 13.356381] PCI: CLS 0 bytes, default 64
>
> Ick, not good. K.Y., any reason why I shouldn't just revert this?

I have asked Wu for details. Examining the relevant VMBUS code, I cannot see
how this patch could be responsible for the freeze. For what it is worth looking at dmesg, it appears that
we are not running on a Hypervisor.

There was a bug in this patch and that was fixed a few days later:

commit 8f257a142fc3868d69de3f996b95d7bdbc509560
Author: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
Date: Tue Dec 27 13:49:37 2011 -0800

Drivers:hv: Fix a bug in vmbus_driver_unregister()

The function vmbus_exists() was introduced recently to deal with cases where
the vmbus driver failed to initialize and yet other Hyper-V drivers attempted
to register with the vmbus bus driver. This patch introduced a bug where
vmbus_driver_unregister() would fail to unregister the driver. This patch
fixes the problem.

Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
Signed-off-by: Fuzhou Chen <fuzhouch@xxxxxxxxxxxxx>
Cc: Sasha Levin <levinsasha928@xxxxxxxxx>
Cc: stable <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Regards,

K. Y

>
> thanks,
>
> greg k-h
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/