Re: [PATCH v4 20/20] ext4: Allow punch hole with bigalloc enabled

From: Lukáš Czerner
Date: Wed Jun 05 2013 - 06:04:51 EST


On Fri, 31 May 2013, Theodore Ts'o wrote:

> Date: Fri, 31 May 2013 11:14:54 -0400
> From: Theodore Ts'o <tytso@xxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx,
> akpm@xxxxxxxxxxxxxxxxxxxx, hughd@xxxxxxxxxx
> Subject: Re: [PATCH v4 20/20] ext4: Allow punch hole with bigalloc enabled
>
> On Tue, May 14, 2013 at 06:37:34PM +0200, Lukas Czerner wrote:
> > In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and
> > 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole
> > implementation and there is noting holding us back from using punch hole
> > on file system with bigalloc feature enabled.
> >
> > This has been tested with fsx and xfstests.
> >
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> > Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> This patch is causing a test failure with bigalloc enabled with the
> xfstests shared/298.
>
> Since it's at the end of the invalidate page range tests, I'm going to
> drop this patch for now. Could you take a look at this?

Hi Ted,

sorry for the delay, I've been on vacation last week so I am trying
to catch on the recent development :) I'll take a look at it
hopefully this week. Thanks for letting me know.

-Lukas

>
> Thanks!!
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/