Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

[Wolfram Sang]

On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> If a device have sleep and idle states in addition to the
> default state, look up these in the core and stash them in
> the pinctrl state container.
> 
> Add accessor functions for pinctrl consumers to put the pins
> into "default", "sleep" and "idle" states passing nothing but
> the struct device * affected.
> 
> Solution suggested by Kevin Hilman, Mark Brown and Dmitry
> Torokhov in response to a patch series from Hebbar
> Gururaja.
> 
> Cc: Hebbar Gururaja <gururaja.hebbar@xxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Kevin Hilman <khilman@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Some nits:

> +	if (IS_ERR(pins->sleep_state))
> +		return 0; /* No default state */

Comment wants to say "sleep state"?

> +	ret = pinctrl_select_state(pins->p, pins->sleep_state);
> +	if (ret)
> +		dev_err(dev, "failed to activate sleep pinctrl state\n");

Better say "pinctrl sleep state"?

> +	if (IS_ERR(pins->idle_state))
> +		return 0; /* No default state */
> +	ret = pinctrl_select_state(pins->p, pins->idle_state);
> +	if (ret)
> +		dev_err(dev, "failed to activate idle pinctrl state\n");

Similar issues here...

Other than that, on all 3 patches:

Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: Digital signature