Re: [PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

From: Geert Uytterhoeven
Date: Thu Jun 06 2013 - 03:08:56 EST


On Thu, Jun 6, 2013 at 1:48 AM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> - strncpy(containerpath, optarg, strlen(optarg) + 1);
>> + strlcpy(containerpath, optarg, sizeof(containerpath));
>> break;
>> case 'w':
>> logfile = strdup(optarg);
>
> Documentation/accounting/getdelays.c:26:24: fatal error: bsd/string.h: No such file or directory

sudo apt-get install libbsd-dev

strlcpy() is available almost everywhere, except in glibc, cfr.
http://en.wikibooks.org/wiki/C_Programming/C_Reference/nonstandard/strlcpy#Criticism

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/