Re: [PATCH v3 1/7] pcmcia: at91_cf: fix gpio_get_value inat91_cf_get_status

From: Jean-Christophe PLAGNIOL-VILLARD
Date: Thu Jun 06 2013 - 12:39:33 EST


On 10:24 Thu 06 Jun , Nicolas Ferre wrote:
> From: Joachim Eastwood <manabian@xxxxxxxxx>
>
> Commit 80af9e6d (pcmcia at91_cf: fix raw gpio number usage) forgot
> to change the parameter in gpio_get_value after adding gpio
> validation.

this is a fix so should for in stable tree too

since #3.4

Best Regards,
J.
>
> Signed-off-by: Joachim Eastwood <manabian@xxxxxxxxx>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> ---
> drivers/pcmcia/at91_cf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 01463c7..1b2c631 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -100,9 +100,9 @@ static int at91_cf_get_status(struct pcmcia_socket *s, u_int *sp)
> int vcc = gpio_is_valid(cf->board->vcc_pin);
>
> *sp = SS_DETECT | SS_3VCARD;
> - if (!rdy || gpio_get_value(rdy))
> + if (!rdy || gpio_get_value(cf->board->irq_pin))
> *sp |= SS_READY;
> - if (!vcc || gpio_get_value(vcc))
> + if (!vcc || gpio_get_value(cf->board->vcc_pin))
> *sp |= SS_POWERON;
> } else
> *sp = 0;
> --
> 1.8.2.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/