Re: [PATCH 1/1] keucr: restored lost line

[Greg KH]

On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
> 
> Signed-off-by: Laura Lawniczak <laura.lawniczak@xxxxxxxxxxxxxx>
> ---
>  drivers/staging/keucr/transport.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/keucr/transport.c b/drivers/staging/keucr/transport.c
> index 1f9ea58..c47a035 100644
> --- a/drivers/staging/keucr/transport.c
> +++ b/drivers/staging/keucr/transport.c
> @@ -131,6 +131,7 @@ static void usb_stor_print_cmd(struct us_data *us, struct scsi_cmnd *srb)
>  		break;
>  	}
>  	bn = 0;
> +	blen = 0;

Really?  If it's unused, why do you want to set it to something?  Any
why is bn set to 0 at the end of the function as well?

Shouldn't both of these lines be removed, and the variable itself
removed too?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/