Re: [ 044/184] ALSA: ice1712: Initialize card->private_data

[Willy Tarreau]

Hi Takashi,

On Fri, Jun 07, 2013 at 08:12:05AM +0200, Takashi Iwai wrote:
> > > This bug appears to have been introduced in Linux 3.8 and doesn't need
> > > fixing in 2.6.32.
> > 
> > Ah indeed that's true. Does it harm to have it or not ?
> 
> It's harmless.
> 
> > because I'm
> > still seeing a number of places where we have this in the driver :
> > 
> >    struct snd_ice1712 *ice = ac97->private_data;
> 
> These are different object types.  The reference of card->private_data
> was introduced recently as Ben pointed out.

Ah sorry I was confused.

> > I'd like to be sure that no other function risks to dereference the
> > same pointer. Also, I'm noting that 3.0/3.4 have this fix, while 3.2
> > does not. So I'm hesitant what to do with this patch.
> 
> Just overlooked in 3.0/3.4 reviews :-<
> 
> But it's utterly harmless, we don't have to remove it from 3.0/3.4, I
> think.  
> 
> For 2.6.32, better to get rid of it from the queue, if it's not too
> late.

Perfect, thanks for the detailed explanation, I'm removing it now.

Best regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/