Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

[Johan Hovold]

On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

> @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i
>  	 */
>  	serial->disconnected = 1;
>  
> -	if (get_free_serial(serial, num_ports, &minor) == NULL) {
> +	if (get_free_serial(serial, num_ports)) {
>  		dev_err(ddev, "No more free serial devices\n");
>  		goto probe_error;
>  	}
> -	serial->minor = minor;

This gives a warning as minor is no longer initialised, but is still
used to initialise the console a bit further down.

	usb_serial_console_init(minor);

Should probably just drop minor, and use serial->port[0]->minor instead.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/