Re: [PATCH -mm 1/1] audit: cleanup audit_log_start/wait_for_auditdmess

[Oleg Nesterov]

On 06/06, Andrew Morton wrote:
>
> On Mon, 3 Jun 2013 22:46:20 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > audit_log_start() tries to obfusticate the code/logic and
> > reimplements wait_event_timeout() in a very confusing way.
> >
> > Just change wait_for_auditd() to use wait_event_timeout()
> > and return bool.
> >
> > Also remove the unnecessary "ab = NULL" initialization.
>
> I would prefer that this be nicely tested - for a cosmetic thing I
> don't think it's worth the risk as-is.

OK, agreed. Please ignore.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/