Re: [PATCH] ethernet/arc/arc_emac - Add new driver
From: Arnd Bergmann
Date: Fri Jun 07 2013 - 08:48:26 EST
On Friday 07 June 2013 12:37:24 Alexey Brodkin wrote:
> On 06/07/2013 04:13 PM, Arnd Bergmann wrote:
> >>> I wonder if it would be better to name the directory "synopsys" or
> >>> "designware" rather than "arc" now. Is there a chance that the same
> >>> controller is used on non-arc CPUs?
> >>
> >> The thing is - "arc_emac" is a custom ARC's (that was implemented before
> >> acquisition of ARC by Synopsys) IP (it's not an IC - just a part of CPU)
> >> Ethernet controller that only exists in some legacy FPGA boards we
> >> (ex-ARC and our customers) still use a lot in development process.
> >>
> >> Synopsys itself doesn't actively sell this device so there's no point in
> >> putting ARC EMAC into Synopsys folder.
> >>
> >> And indeed we don't expect this device to be used with non-ARC CPU's.
>
> I'm wondering if my clarification above makes sense and I may leave this
> driver in "ethernet/arc" or you still prefer it to be under
> "ethernet/synopsys"?
Yes, I think if we don't expect any future Synopsys/Designware branded
devices to use this, using ethernet/arc is fine.
The main reason to still use a different name is so we will be able
to group it with other drivers for designware ethernet controllers.
The only one I'm currently aware of is drivers/net/ethernet/stmicro/stmmac/.
If we wanted to ahve a designware directory, we should probably move that
as well.
I'll leave it up to you (or Dave, if he has a strong opinion).
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/