Re: [PATCH 8/8] isdn: clean up debug format string usage

[Kees Cook]

On Thu, Jun 6, 2013 at 1:52 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> Avoid unneeded local string buffers for constructing debug output. Also
> cleans up debug calls that contain a single parameter so that they cannot
> be accidentally parsed as format strings.
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Karsten Keil <isdn@xxxxxxxxxxxxxx>
> [...]
> diff --git a/drivers/isdn/mISDN/dsp_pipeline.c b/drivers/isdn/mISDN/dsp_pipeline.c
> index 8b1a66c..88305c9 100644
> --- a/drivers/isdn/mISDN/dsp_pipeline.c
> +++ b/drivers/isdn/mISDN/dsp_pipeline.c
> @@ -102,7 +102,7 @@ int mISDN_dsp_element_register(struct mISDN_dsp_element *elem)
>         entry->dev.class = elements_class;
>         entry->dev.release = mISDN_dsp_dev_release;
>         dev_set_drvdata(&entry->dev, elem);
> -       dev_set_name(&entry->dev, "%s", elem->name);
> +       dev_set_name(&entry->dev, elem->name);
>         ret = device_register(&entry->dev);
>         if (ret) {
>                 printk(KERN_ERR "%s: failed to register %s\n",

This hunk should be dropped -- it got mixed up when splitting the
dev_set_name() patch out.

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/