Re: [PATCH] dmatest: add ability to disable pq and xor

[Andy Shevchenko]

On Tue, Jun 4, 2013 at 8:11 PM, Dan Williams <djbw@xxxxxx> wrote:
> On 6/4/13 12:25 AM, "Andy Shevchenko" <andy.shevchenko@xxxxxxxxx> wrote:
>>On Tue, Jun 4, 2013 at 2:29 AM, Jon Mason <jon.mason@xxxxxxxxx> wrote:
>>> On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote:

[]

>>>  Since the testing is started immediately upon module
>>> insertion,
>>It used to be so, but nowadays it's true only when dmatest is compiled in.
>>If someone wants to compile in that module they probably want to run
>>stress tests, where XOR and PQ might be useful.
>
> ...and they would want the test selection to be specified on the kernel
> command line.  At least that's how I used compiled in dmatest in the past.

Actually you're right. Better to have it in that case too.

>>My opinion I already shared, new node under debugfs. There is might be
>>a good reason to add a new module parameter as well.
>
> I'm not seeing why debugfs is helpful here.  Just make it a module
> parameter that calls a routine to setup the bit mask.

I'm not objecting against module parameter, though I would like to see
debugfs node for that as well.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/