Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

[Michael Holzheu]

On Sat, 8 Jun 2013 11:38:00 +0400
Maxim Uvarov <muvarov@xxxxxxxxx> wrote:

[snip]

> > +static int copy_to(void *target, void *src, size_t size, int
> > userbuf) +{
> > +       if (userbuf) {
> > +               if (copy_to_user(target, src, size))
> > +                       return -EFAULT;
> > +               return 0;
> > +       } else {
> > +               memcpy(target, src, size);
> > +               return 0;
> > +       }
> > +}
> >  
> 
> It is better to do return 0 in the end of function.

Sure, I will change that.

Thanks!
Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/