Re: [PATCH] pwm: devm: alloc correct pointer size

[Thierry Reding]

On Mon, Jun 10, 2013 at 09:41:52AM +0300, Andy Shevchenko wrote:
> On Mon, Jun 10, 2013 at 3:04 AM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > On Thu, Jun 06, 2013 at 10:43:41PM +0300, Andy Shevchenko wrote:
> >> On Mon, Jun 3, 2013 at 11:27 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> >> > The allocated object should be the size of what the pointer is pointing
> >> > to and not the size of the pointer itself.
> >>
> >> All devm_* functions in this module use **ptr as a parameter (except
> >> allocation).
> >> May be we first should understand why it so?
> >
> > Huh? **ptr is already created on the stack, but assigned the alloced
> > memory. Later, the mem it points to is set to 'pwm' which is then added
> > to devres. So, the alloced memory must be able to contain '*ptr' (or
> > *pwm which would be more readable IMO, but other subsystems also stick
> > to *ptr), no?
> 
> Yes, you right.
> Take my Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Applied, thanks.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature