Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

[HATAYAMA Daisuke]

2013/6/8 Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx>:
<cut>
> @@ -935,10 +967,17 @@ static int __init vmcore_init(void)
>  {
>         int rc = 0;
>
> -       /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/
> -       if (!(is_vmcore_usable()))
> -               return rc;
> +       /*
> +        * If elfcorehdr= has not been passed in cmdline, try to get the
> +        * header from 2nd kernel, then capture the dump.
> +        */
> +       if (!(is_vmcore_usable())) {
> +               rc = elfcorehdr_alloc();
> +               if (rc)
> +                       return rc;
> +       }

Here you removed comment in the 1st path. Please keep it.

Thanks.
HATAYAMA, Daisuke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/