Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent)card. Kernel version 3.4.47

From: Oded Gabbay
Date: Mon Jun 10 2013 - 12:45:11 EST


Hi All,

Just noticed that 3.4.47/8 doesn't have the mmc_of_parse (compared to 3.9.4).
Therefore, I will not use it and just fix the code to recognize the property "non-removable"

Best regards,
Oded

On 06/10/2013 04:43 PM, Oded Gabbay wrote:
Hi Dirk,

You are absolutely right.
I will revise my patch series to reflect the change.
Basically, I will call the generic mmc_of_parse from the probe function of Freescale's driver.
That will handle all the additional capabilities.

Thanks
Oded

On 06/10/2013 09:29 AM, Dirk Behme wrote:
On 02.06.2013 08:38, Oded Gabbay wrote:
This patch adds support of recognizing hard-wired (permanent) cards
to Freescale's SDHC host driver. This is done by adding the option
"fsl,card-wired" to the SDHC device-tree entry. Detection of this
option is done in the probe function. Update documentation in file
fsl-esdhc.txt

Why don't you want to introduce "fsl,card-wired"? Why don't you use "non-removable"?

To my understanding the patch

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7f217794ffa72f208a250b79ab0b7ea3de19677f


explicitly removed "fsl,card-wired". So I don't think re-introducing it is a good idea?

Best regards

Dirk


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/