Re: [checkpatch] - Confusion

[PINTU KUMAR]

>________________________________
> From: anish singh <anish198519851985@xxxxxxxxx>
>To: PINTU KUMAR <pintu_agarwal@xxxxxxxxx> 
>Cc: "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>; "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx> 
>Sent: Sunday, 9 June 2013 10:58 PM
>Subject: Re: [checkpatch] - Confusion
> 
>
>On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR <pintu_agarwal@xxxxxxxxx> wrote:
>> Hi,
>>
>> I wanted to submit my first patch.
>> But I have some confusion about the /scripts/checkpatch.pl errors.
>>
>> After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors.
>> But when I create patches are git format-patch, it is showing me 1 error.
>did  you run the checkpatch.pl on the file which gets created
>after git format-patch?
>If yes, then I think it is not necessary.You can use git-am to apply
>your own patch on a undisturbed file and if it applies properly then
>you are good to go i.e. you can send your patch.

Yes, first I ran checkpatch directly on the file(mm/page_alloc.c) and fixed all the errors.
It showed me (0) errors.
Then I created a patch using _git format-patch_ and ran checkpatch again on the created patch.
But now it is showing me 1 error.
According to me this error is false positive (irrelevant), because I did not change anything related to the error and also the similar change already exists somewhere else too.
Do you mean, shall I go ahead and submit the patch with this 1 error??
ERROR: need consistent spacing around '*' (ctx:WxV)

#153: FILE: mm/page_alloc.c:5476:
+int min_free_kbytes_sysctl_handler(ctl_table *table, int write,



>>
>> If I fix error in patch, it showed me back again in files.
>>
>> Now, I am confused which error to fix while submitting patches, the file or the patch errors.
>>
>> Please provide your opinion.
>>
>> File: mm/page_alloc.c
>> Previous file errors:
>> total: 16 errors, 110 warnings, 6255 lines checked
>>
>> After fixing errors:
>> total: 0 errors, 105 warnings, 6255 lines checked
>>
>>
>> And, after running on patch:
>> ERROR: need consistent spacing around '*' (ctx:WxV)
>> #153: FILE: mm/page_alloc.c:5476:
>> +int min_free_kbytes_sysctl_handler(ctl_table *table, int write,
>>
>>
>>
>>
>> - Pintu
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/