Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN

From: Pekka Enberg
Date: Tue Jun 11 2013 - 11:16:16 EST


On Tue, 11 Jun 2013, Sasha Levin wrote:
I think that leaving the warning makes sense to catch similar
things which are actually bugs - we had a similar issue with
/dev/kmsg (if I remember correctly) which actually pointed to
a bug.

On 6/11/13 6:14 PM, Christoph Lameter wrote:
Right. Requesting an allocation larger than even supported by the page
allocator from the slab allocators that are specializing in allocations of
small objects is usually an indication of a problem in the code.

So you're OK with going forward with Sasha's patch? It's needed
because __GFP_NOWARN was specifically added there to fix this
issue earlier.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/