Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lrulists

From: Kirill A. Shutemov
Date: Tue Jun 11 2013 - 12:24:35 EST


Dave Hansen wrote:
> On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote:
> > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages
> > that have been placed on the LRU lists when first allocated), but these
> > pages must not have PageUnevictable set - otherwise shrink_[in]active_list
> > goes crazy:
>
> I think it's also important here to note if this is a bug that can be
> hit _currently_, or if this really is just a preparatory patch for
> transparent huge page cache.

I've mentioned in cover letter, that don't think the bug can be triggered on
current upstream code.

> From what I can see, this is _needed_ preparatory work, but it can also
> stand on its own because it simplifies things. It should go in sooner
> rather than later.

Right.

--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/