Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xxplatform

From: Sergei Shtylyov
Date: Tue Jun 11 2013 - 14:52:52 EST


Hello.

On 06/11/2013 01:45 PM, B, Ravi wrote:

+
+ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup");
+ phy->phy_wkup = ioremap(res->start, resource_size(res));

devm_ioremap?

The phy_wakeup register is common across two instances of phy, devm_ioremap_resource() will fail to map for twice for same register space.

I've already told you the register can't be shared between devices like this. BTW, you haven't replied to my request concerning your /proc/iomem contents...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/