Re: [PATCH] PM / Sleep: Print last wakeup source on failedwakeup_count write

From: Julius Werner
Date: Tue Jun 11 2013 - 19:20:32 EST


Resending as plain text... sorry for the spam, Gmail just likes to
silently mess up my settings every once in a while.

On Tue, Jun 11, 2013 at 4:17 PM, Julius Werner <jwerner@xxxxxxxxxxxx> wrote:
>
>> This is going to be done in the autosleep case too, which I'm slightly
>> concerned about.
>>
>> If you wanted to cover /sys/power/wakeup_count only, it would be better
>> to put that into wakeup_count_store(), but perhaps you wanted to cover
>> autosleep too?
>
>
> Hmm... no, I did not really take the autosleep case into account. I can't
> quite tell with what frequency the autosleep try_to_suspend() handler on an
> active system would run... do you think it might be a useful feature to have
> there, or would it lead to logspam?
>
> I can move it to wakeup_count_store() if you prefer, but then I will have to
> turn print_active_wakeup_sources() into an exported function, which is also
> a little inconvenient.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/