Re: [PATCH net-next 2/2] net:add socket option for low latency polling

[Eliezer Tamir]

On 11/06/2013 23:24, Ben Hutchings wrote:
> On Tue, 2013-06-11 at 17:24 +0300, Eliezer Tamir wrote:
> > adds a socket option for low latency polling.
> > This allows overriding the global sysctl value with a per-socket one.
> [...]
> > --- a/net/core/sock.c
> > +++ b/net/core/sock.c
> > @@ -913,6 +913,23 @@ set_rcvbuf:
> >   		sock_valbool_flag(sk, SOCK_SELECT_ERR_QUEUE, valbool);
> >   		break;
> >
> > +#ifdef CONFIG_NET_LL_RX_POLL
> > +	case SO_LL:
> > +		if (!capable(CAP_NET_ADMIN))
> > +			ret = -EACCES;
> [...]
>
> Failed capability checks normally result in EPERM whereas EACCES usually
> results from a file permission/ACL/label check.

OK

> Perhaps unprivileged users should be allowed to set a value as long as
> it's less than or equal to the global value?

I thought of allowing to disable even if you are not privileged, but 
this sounds better.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/