Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

[Andy Shevchenko]

On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote:
>> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
>>
>> []
>>
>> > Something like
>> > config DW_DMAC_BIG_ENDIAN_IO
>> >         tristate
>> >
>> > config DW_DMAC
>> >         select DW_DMAC_BIG_ENDIAN_IO
>> >
>> > I belive DW_DMAC is for AVR support and the PCI ones is different right.
>> > The point is that these things should be selected by the required symbols based
>> > on what ARCH we are on and not be prompted for user to configure via menuconfig
>>
>> DW_DMAC is a generic platform driver which supports AVR32, ARM and
>> Intel (ACPI case) platforms.
>>
>> We may do that option invisible to user
> Yup
>>
>> and then use
>>
>> config DW_DMAC
>>          select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32
> Thats would be the right way

Do you prefer to have this as separate patch or integrated in the split?
In my humble opinion I better to do separate patch.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/