[PATCH] staging: tidspbridge: Fix potential NULL pointer dereference

From: Emil Goode
Date: Wed Jun 12 2013 - 10:33:32 EST


We free dcd_key on line 897 and then dereference it a few lines below.
This patch adds a NULL check to make sure we can use dcd_key.

Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>
---
drivers/staging/tidspbridge/rmgr/dbdcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/tidspbridge/rmgr/dbdcd.c b/drivers/staging/tidspbridge/rmgr/dbdcd.c
index 3d2a26f..21ce3b7 100644
--- a/drivers/staging/tidspbridge/rmgr/dbdcd.c
+++ b/drivers/staging/tidspbridge/rmgr/dbdcd.c
@@ -899,7 +899,7 @@ int dcd_register_object(struct dsp_uuid *uuid_obj,
}
}
spin_unlock(&dbdcd_lock);
- if (&dcd_key->link == &reg_key_list)
+ if (dcd_key && (&dcd_key->link == &reg_key_list))
status = -EPERM;
}

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/