Re: [PATCH] x86, relocs: move ELF relocation handling to C
From: H. Peter Anvin
Date: Wed Jun 12 2013 - 14:15:15 EST
On 06/12/2013 11:13 AM, Yinghai Lu wrote:
>
> it seems those lines for x86_64 are never used.
> as X86_NEED_RELOCS is not defined for x86_64
>
>> config X86_NEED_RELOCS
>> def_bool y
>> depends on X86_32 && RELOCATABLE
>
>
>> +}
>> +#else
>> +static inline void handle_relocations(void *output, unsigned long output_len)
>> +{ }
>> +#endif
>
> Can you make it clear that this patch only affect x86_32 in patch title?
>
I am not sure this belongs in the patch title, as it is preparatory work
for x86-64. It should be mentioned in the patch description body, though.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/