Re: [PATCH 3.0-stable 1/2] tracing: Fix possible NULL pointer dereferences

From: Li Zefan
Date: Wed Jun 12 2013 - 21:49:35 EST


On 2013/6/11 5:13, Greg Kroah-Hartman wrote:
> On Fri, Jun 07, 2013 at 05:00:33PM +0800, Li Zefan wrote:
>> commit 6a76f8c0ab19f215af2a3442870eeb5f0e81998d upstream.
>>
>> Currently set_ftrace_pid and set_graph_function files use seq_lseek
>> for their fops. However seq_open() is called only for FMODE_READ in
>> the fops->open() so that if an user tries to seek one of those file
>> when she open it for writing, it sees NULL seq_file and then panic.
>
> You lost the original authorship of this patch, which is a very bad
> thing to do.
>

Oops, my bad.

> Ugh, time to edit emails by hand, not my favorite pasttime, someone owes
> me a drink...
>

Sure, maybe at Plumber. ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/