Re: [PATCH v3 net-next 3/4] net: change sysctl_net_ll_poll into anunsigned int

[Eric Dumazet]

On Thu, 2013-06-13 at 17:46 +0300, Eliezer Tamir wrote:
> There is no reason for sysctl_net_ll_poll to be an unsigned long.
> Change it into an unsigned int.
> Fix the proc handler.
> 
> Signed-off-by: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
> ---
> 
>  include/net/ll_poll.h      |    2 +-
>  net/core/sysctl_net_core.c |    4 ++--
>  net/socket.c               |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h
> index c75a611..9f7007f 100644
> --- a/include/net/ll_poll.h
> +++ b/include/net/ll_poll.h
> @@ -30,7 +30,7 @@
>  #ifdef CONFIG_NET_LL_RX_POLL
>  
>  struct napi_struct;
> -extern unsigned long sysctl_net_ll_poll __read_mostly;
> +extern unsigned int sysctl_net_ll_poll __read_mostly;
>  

Oh well, you re-introduce the overflow

hint : you defined 

#define USECS_TO_NS(us) (us << 10)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/