Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

[Bjorn Helgaas]

On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> This fixes a copy and paste error introduced by 9f060e2231
> ("block: Convert integrity to bvec_alloc_bs()").
>
> Found by Coverity (CID 1020654).
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
>  fs/bio-integrity.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 8fb4291..45e944f 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>                 mempool_destroy(bs->bio_integrity_pool);
>
>         if (bs->bvec_integrity_pool)
> -               mempool_destroy(bs->bio_integrity_pool);
> +               mempool_destroy(bs->bvec_integrity_pool);
>  }
>  EXPORT_SYMBOL(bioset_integrity_free);

Kent, do you want to chime in on this?  Looks like an obvious error to
me, but maybe I'm missing something and we should teach Coverity to
shut up about it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/