Re: [PATCH] pwm: Fill in missing .owner fields

From: Thierry Reding
Date: Thu Jun 13 2013 - 14:23:40 EST


On Thu, Jun 13, 2013 at 12:33:13AM +0200, Lars-Peter Clausen wrote:
> On 06/12/2013 09:59 PM, Thierry Reding wrote:
> > On Wed, Jun 12, 2013 at 05:05:18PM +0530, Sachin Kamat wrote:
> >> Hi Thierry,
> >>
> >> On 12 June 2013 16:59, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> >>> Some drivers don't set the .owner fields of the struct device_driver or
> >>> struct pwm_ops, which causes the module usage count to become wrong.
> >>
> >>
> >> Recently a patch [1] was added to solve this issue of missing .owner
> >> fileds in struct platform_driver.
> >
> > Yes I saw that, but thought it might be good to initialize them anyway.
> > Especially since a couple of the drivers are I2C and I believe there's
> > no similar patch for those. It shouldn't be difficult to come up with
> > the corresponding patch, though.
>
> I2C had the same actually for quite some time now.

I wasn't aware of that. Thanks for educating me. =)

Thierry

Attachment: pgp00000.pgp
Description: PGP signature