Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void__iomem *
From: Marc Kleine-Budde
Date: Thu Jun 13 2013 - 15:20:07 EST
On 06/13/2013 08:24 PM, Thierry Reding wrote:
> On Thu, Jun 13, 2013 at 10:55:17AM +0530, Sachin Kamat wrote:
>> On 13 June 2013 03:01, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>>> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
>>> introduced devm_ioremap_resource() and encourage to check its return value with
>>> IS_ERR(). This however leads to the following sparse warnings, as
>>> devm_ioremap_resource() returns a void __iomem pointer:
>>>
>>> drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
>>> drivers/net/can/c_can/c_can_platform.c:205:32: expected void const *ptr
>>> drivers/net/can/c_can/c_can_platform.c:205:32: got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg
>>
>> CC ing Thierry who has solved this issue some time back.
>
> I had sent two patches, one against sparse, the other against the
> kernel, but none were picked up yet.
Can you repost them? Hope someone will pick them up.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature