RE: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

[Kukjin Kim]

Tomasz Figa wrote:
> 
> On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote:
> > Tomasz,
> >
> > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx>
> wrote:
> > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote:
> > >> It's convenient if get_maintainer suggests sending samsung/exynos
> > >> pinctrl changes to linux-samsung-soc and to Kukjin.  Add an entry for
> > >> that.
> > >
> > > Well, if we are already at it, we could list the actual maintainers of
> > > the driver.
> > >
> > > The original maintainer was Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> > > (added to CC) and after joining to development of this driver last
> > > year I have become a de facto maintainer as well, so...
> > >
> > >> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> > >> ---
> > >>
> > >>  MAINTAINERS | 10 ++++++++++
> > >>  1 file changed, 10 insertions(+)
> > >>
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index 8d97b3e..d026e38 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -6284,6 +6284,16 @@ L:     linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > >> (moderated for non-subscribers) S:    Maintained
> > >>
> > >>  F:   drivers/pinctrl/pinctrl-at91.c
> > >>
> > >> +PIN CONTROLLER - SAMSUNG
> > >> +M:   Linus Walleij <linus.walleij@xxxxxxxxxx>
> > >> +M:   Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> > >
> > > So actually this would be:
> > > M:      Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> > > M:      Tomasz Figa <t.figa@xxxxxxxxxxx>
> > >
> > > Thomas, do you agree on this?
> >
> > Ah.  Wasn't sure where the official maintainership should lie.  ;)  If
> > Thomas is happy with this then I'll spin and re-send.  Shall I remove
> > Kukjin and Linus, then?  It's convenient to have Linus on the list
> > since he tends to be the one applying the patches...
> 
> From my understanding how it works, there is no need to list Linus in
> particular drivers, because he's already listed as a maintainer of the
> whole pinctrl subsystem and get-maintainer accounts for this.
> 
> Similarly for Kukjin, he's listed as the main Samsung maintainer already,

If so, the directory like pinctrl should be added under Samsung ARM
Architectures like spi and sound for Samsung stuff...

> but AFAIK in this case the script can't infer this based on directory
> structure. Let's see how it's done for other Samsung drivers:
> 
Well, I don't think so, because pinctrl has the close relationship with
exynos arch part and it's little bit different with following. Just in my
understanding.

> DRM DRIVERS FOR EXYNOS
> M:      Inki Dae <inki.dae@xxxxxxxxxxx>
> M:      Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> M:      Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> M:      Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> L:      dri-devel@xxxxxxxxxxxxxxxxxxxxx
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-
> exynos.git
> S:      Supported
> F:      drivers/gpu/drm/exynos
> F:      include/drm/exynos*
> F:      include/uapi/drm/exynos*
> 
> EXYNOS DP DRIVER
> M:      Jingoo Han <jg1.han@xxxxxxxxxxx>
> L:      linux-fbdev@xxxxxxxxxxxxxxx
> S:      Maintained
> F:      drivers/video/exynos/exynos_dp*
> F:      include/video/exynos_dp*
> 
> EXYNOS MIPI DISPLAY DRIVERS
> M:      Inki Dae <inki.dae@xxxxxxxxxxx>
> M:      Donghwa Lee <dh09.lee@xxxxxxxxxxx>
> M:      Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> L:      linux-fbdev@xxxxxxxxxxxxxxx
> S:      Maintained
> F:      drivers/video/exynos/exynos_mipi*
> F:      include/video/exynos_mipi*
> 
> ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT
> M:      Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> M:      Kamil Debski <k.debski@xxxxxxxxxxx>
> L:      linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> L:      linux-media@xxxxxxxxxxxxxxx
> S:      Maintained
> F:      drivers/media/platform/s5p-g2d/
> 
And I'm asking above all guys _really_ do review and maintaining the file or
directories? I don't think so.

> and so on.
> 
> So I think, based on this precedent, we can do the same for pinctrl. Let's
> wait to see Thomas' view on this.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/