Re: [PATCH] Percpu tag allocator

From: Tejun Heo
Date: Thu Jun 13 2013 - 19:23:28 EST


On Thu, Jun 13, 2013 at 04:13:42PM -0700, Tejun Heo wrote:
> On Thu, Jun 13, 2013 at 03:35:51PM -0700, Andrew Morton wrote:
> > Well that's news. My awe at the dreadfulness of Kent's changelog
> > continues to grow. Please identify these duplicated allocators
> > (function names will suffice). That way, others can actually review
> > this code :(
>
> Oh yeah, Kent could and should have sold it much better. :)

BTW, here are three that I know of off the top of my head.

* block/blk-tag.c - this is pretty big and does resizing and stuff.

* drivers/ata/libata-core.c::ata_qc_new()

* drivers/block/nvme-core.c::alloc_cmdid()

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/