Re: [Part3 PATCH v2 2/4] mem-hotplug: Skip LOCAL_NODE_DATA pagesin memory offline procedure.

[Tang Chen]

Hi Dave,

On 06/14/2013 01:17 AM, Dave Hansen wrote:
> On 06/13/2013 06:03 AM, Tang Chen wrote:
> > +static inline bool is_local_node_data(struct page *page)
> > +{
> > +	return (unsigned long)page->lru.next == LOCAL_NODE_DATA;
> > +}
>
> page->lru is already in a union.  Could you please just add a new entry
> to the union with a nice associated comment instead of reusing it this way?

You mean add a new entry to the union in page structure ?

Hum, seems a good idea. :)

And as you know, NODE_INFO, SECTION_INFO, ... , they all reuse page->lru.
So I need to modify the associated code too. This is easy to do, and I can
do it in the next version soon.

Thanks. :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/