Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on WondermediaSoCs

[Tony Prisk]

On 15/06/13 23:18, Wolfram Sang wrote:
> On Sat, Jun 15, 2013 at 09:52:16AM +1200, Tony Prisk wrote:
> > This patch adds support for the I2C bus controllers found on Wondermedia
> > 8xxx-series SoCs. Only master-mode is supported.
> >
> > Signed-off-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>
> > ---
> ...
>
> > +/* REG_TR */
> > +#define SCL_TIMEOUT(x)		(((x) & 0xFF) << 16)
> I assume this should be << 8 since all regs are 16 bit wide.
>
> Fixed it locally and ready to apply. Please confirm or send a proper
> fix. Rest looks fine.
>
> Thanks for the submission!
It should be << 8. Please apply your locally corrected version.

Regards
Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/