Re: [PATCH] net: fec: Fix build for MCF5272

[David Miller]

From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Mon, 17 Jun 2013 13:16:19 -0700

> Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and
> baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G
> network) introduced functionality into the FEC driver which is not
> supported on MCF5272. As result, building images for MCF5272 fails,
> complaining about several undefined symbols.
> 
> Disabled the added functionality for MCF5272 builds.
> 
> Cc: Frank Li <Frank.Li@xxxxxxxxxxxxx>
> Cc: Jim Baxter <jim_baxter@xxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> Sorry for the added ifdefs. If anyone has a better idea on how to fix
> the problems, let me know.
> 
> This problem exists in 3.9 as well.

Does the M5272 not have these registers, or have you simply not added
defines for where there offsets are in that silicon instance?

I'd much rather you add the register offset defines than pepper the
entire driver with ifdefs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/