Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and32bpp

[Hector Palacios]

On 06/18/2013 10:32 AM, maxime.ripard@xxxxxxxxxxxxxxxxxx wrote:
> Hi Hector,
>
> On Fri, Jun 07, 2013 at 11:02:28AM +0200, maxime.ripard@xxxxxxxxxxxxxxxxxx wrote:
> > On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote:
> > > For a combination of 18bit LCD data bus width and a color
> > > mode of 32bpp, the driver was setting the color mapping to
> > > rgb666, which is wrong, as the color in memory realy has an
> > > rgb888 layout.
> > >
> > > This patch also removes the setting of flag CTRL_DF24 that
> > > makes the driver dimiss the upper 2 bits when handling 32/24bpp
> > > colors in a diplay with 18bit data bus width. This flag made
> > > true color images display wrong in such configurations.
> > >
> > > Finally, the color mapping rgb666 has also been removed as nobody
> > > is using it and high level applications like Qt5 cannot work
> > > with it either.
> > >
> > > Reference: https://lkml.org/lkml/2013/5/23/220
> > > Signed-off-by: Hector Palacios <hector.palacios@xxxxxxxx>
> > > Acked-by: Juergen Beisert <jbe@xxxxxxxxxxxxxx>
> >
> > Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> >
> > Please also note that fbdev is now maintained by Jean Christophe
> > Plagniol-Villard (plagnioj@xxxxxxxxxxxx, in CC), and that he is away
> > until the 10th of June, so maybe it should be safe to resend it to him
> > after this date.
>
> It seems like Jean-Christophe is back online, maybe you should resend
> him the patch now, it would be great to have it for 3.11.

I just resent it. Thanks for the reminder.

--
Héctor Palacios

Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/