Re: [PATCH 1/1] drivers/net: param for lapbether for specific ethernetdevice

[Stephen Moorby]

I will be using an Ubuntu 10.04 kernel with the 'eth_dev' module 
parameter patch.  I appreciate a better solution needs to be designed 
but it is not one I can contribute to.  I still advocate the patch as an 
improvement on the current non functional situation.

On 19/06/13 20:18, David Miller wrote:
> From: Stephen Moorby <steve.moorby@xxxxxxxxxxxx>
> Date: Wed, 19 Jun 2013 16:26:53 +0100
>
> > The lapbether driver binds to the first ethernet device that comes up.
> > This causes problems in hardware with multiple ethernet interfaces,
> > potentially resulting in the LAPB traffic on the wrong interface.
> > Have added a module parameter 'eth_dev' to specify the ethernet
> > interface over which lapbether should operate.  The module behaves
> > as before if no device is specified.
> >
> > Patch created on linux-next 18-Jun-2013.
> > Tested on 2.6.32-45-generic.
> >
> > Signed-off-by: Stephen Moorby <steve.moorby@xxxxxxxxxxxx>
> I rejected this patch last night, stating that module parameters are
> deeply discouraged and therefore you need to create a runtime mechanism
> to control this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/