Re: [patch v8 4/9] sched: fix slept time double counting in enqueueentity
From: Alex Shi
Date: Thu Jun 20 2013 - 10:59:49 EST
On 06/20/2013 10:46 AM, Lei Wen wrote:
>
>
> But here I have a question, there is another usage of __synchronzie_entity_decay
> in current kernel, in the switched_from_fair function.
>
> If task being frequently switched between rt and fair class, would it
> also bring the
> redundant issue? Do we need patch like below?
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b5408e1..9640c66 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5856,7 +5856,7 @@ static void switched_from_fair(struct rq *rq,
> struct task_struct *p)
> */
> if (p->se.avg.decay_count) {
> struct cfs_rq *cfs_rq = cfs_rq_of(&p->se);
> - se->avg.last_runnable_update +=
> + p->se.avg.last_runnable_update +=
what tree does this patch base on?
> __synchronize_entity_decay(&p->se);
> subtract_blocked_load_contrib(cfs_rq,
> p->se.avg.load_avg_contrib);
--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/