Re: linux-next: build failure after merge of the leds tree

[Grant Likely]

On Fri, Jun 21, 2013 at 1:16 AM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi Guys,
>
> On Mon, 17 Jun 2013 10:26:31 +0400 Alexander Shiyan <shc_work@xxxxxxx> wrote:
>>
>> > After merging the leds tree, today's linux-next build (x86_64
>> > allmodconfig) failed like this:
>> >
>> > drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe':
>> > drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
>> >     child = of_get_next_child(parent, child);
>> >     ^
>> >
>> > Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support").  of_get_next_child() is only defined if CONFIG_OF is set.
>> >
>> > I have used the version of the leds tree from next-20130607 for today.
>>
>> The patch has already been sent by me.
>> http://www.spinics.net/lists/linux-leds/msg00994.html
>
> I anything happening about this?  That patch would need to go into the
> leds tree (with acks from devicetree people - Grant cc'd).

I've gone and looked at the patch. It should be reverted and
revisited. It interleaves a bunch of DT calls with non-DT calls which
the absence of empty stubs when !CONFIG_OF is intended to catch.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/