Re: [PATCH] nbd: correct disconnect behavior

[Rob Landley]

On 06/19/2013 04:09:18 PM, Paul Clements wrote:
> Currently, when a disconnect is requested by the user (via  
> NBD_DISCONNECT
> ioctl) the return from NBD_DO_IT is undefined (it is usually one of
> several error codes). This means that nbd-client does not know if a
> manual disconnect was performed or whether a network error occurred.
> Because of this, nbd-client's persist mode (which tries to reconnect  
> after
> error, but not after manual disconnect) does not always work  
> correctly.
>
> This change fixes this by causing NBD_DO_IT to always return 0 if a  
> user
> requests a disconnect. This means that nbd-client can correctly either
> persist the connection (if an error occurred) or disconnect (if the  
> user
> requested it).
>
> Signed-off-by: Paul Clements <paul.clements@xxxxxxxxxxxx>

Is _that_ what it was?

(Guy who wrote the busybox NBD client and never did quite understand  
the disconnect/reconnect behavior.)

Acked-by: Rob Landley <rob@xxxxxxxxxxx>

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/