Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

[Kishon Vijay Abraham I]

Hi,

On Saturday 22 June 2013 06:42 PM, Laxman Dewangan wrote:
> On Friday 21 June 2013 07:30 PM, Kishon Vijay Abraham I wrote:
> > On Friday 21 June 2013 06:55 PM, Laxman Dewangan wrote:
> > > On Thursday 20 June 2013 08:56 PM, Kishon Vijay Abraham I wrote:
> > > > Hi,
> > > >
> > > > On Thursday 20 June 2013 08:14 PM, Laxman Dewangan wrote:
> > > > > Have you added the regulator supply entries?
> > > > > Are you testing on mainline linux-next?
> > > > Not in linux-next :-( Tested only with mainline.
> > > > Does inverting the order helps?
> > > I think because you do not have entry of supply in your dt node, it gets
> > > ignored by regulator_dev_lookup() and continue.
> > >
> > > I made the entry like (added entry form smps10-out2-supply and smps10-in-supply
> > > in dt node) and then it failed.
> > > /***
> > >
> > > +                           smps10-out2-supply = <&palmas_smps10_out2_reg>;
> > > +                           smps10-in-supply = <&tps65090_dcdc3_reg>;
> > >                               ldo3-in-supply = <&palmas_smps3_reg>;
> > > @@ -903,6 +905,20 @@
> > >                                           regulator-always-on;
> > >                                   };
> > >
> > > +                               palmas_smps10_out1_reg: smps10_out1 {
> > > +                                       regulator-name = "smps10_out1";
> > > +                                       regulator-min-microvolt = <5000000>;
> > > +                                       regulator-max-microvolt = <5000000>;
> > > +                                       regulator-always-on;
> > > +                               };
> > > +
> > > +                               palmas_smps10_out2_reg: smps10_out2 {
> > > +                                       regulator-name = "smps10_out2";
> > > +                                       regulator-min-microvolt = <5000000>;
> > > +                                       regulator-max-microvolt = <5000000>;
> > > +                                       regulator-always-on;
> > > +                               };
> > > +
> > > **/
> > >
> > >
> > > After reversing the sequence, it worked fine.
> > You mean, changing the order in dt node helped?
>
> The sequence on DT does not matter. We register the regulators in the sequence
> it is having enums value for regulator-id in loop. So we need to revert there.
>
> Yaah, it looks odd that SMPS10-OUT2come before SMPS10-OUT1 in enums definition.

Will fix that and send a patch.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/