Re: [PATCH] block:Remove extra condition in end of disk check

[Tejun Heo]

On Mon, Jun 24, 2013 at 07:20:12PM +0530, Raghavendra K T wrote:
> >@@ -1656,7 +1656,7 @@ static inline int bio_check_eod(struct bio *bio, unsigned int nr_sectors)
> >  	if (maxsector) {
> >  		sector_t sector = bio->bi_sector;
> >
> >-		if (maxsector < nr_sectors || maxsector - nr_sectors < sector) {
> >+		if (maxsector - nr_sectors < sector) {

If maxsector < nr_sectors, the subtraction will underflow making it a
very large number and fail to detect the invalid condition, no?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/