Re: [PATCH RESEND V7 25/30] thermal: exynos: Add hardware mode thermalcalibration support

From: Eduardo Valentin
Date: Tue Jun 25 2013 - 09:39:09 EST

Next message: Mark Salter: "Re: linux-next: problem trying to fetch the c6x tree"
Previous message: Roger Quadros: "Re: [PATCH V2] USB: initialize or shutdown PHY when add or removehost controller"
In reply to: Amit Daniel Kachhap: "[PATCH RESEND V7 25/30] thermal: exynos: Add hardware mode thermal calibration support"
Next in thread: Amit Daniel Kachhap: "[PATCH V7 27/30] ARM: dts: thermal: exynos: Add documentation for Exynos SoC thermal bindings"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 25-06-2013 07:46, Amit Daniel Kachhap wrote:
> This patch adds support for h/w mode calibration in the TMU controller.
> Soc's like 5440 support this features. The h/w supports two point calibration
> and one point calibration at 85C and 25C.
>
> Acked-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx>

Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxx>

> ---
> Changes in this patch fixes a setting up of wrong calibration mode by defining
> trim type for 25 and 85C. This will be only used in H/W based calibration.
>
> drivers/thermal/samsung/exynos_tmu.c | 33 ++++++++++++++++++++++++++++-
> drivers/thermal/samsung/exynos_tmu.h | 8 +++++++
> drivers/thermal/samsung/exynos_tmu_data.c | 2 +
> drivers/thermal/samsung/exynos_tmu_data.h | 2 +
> 4 files changed, 44 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 3fac0f9..a6fc379 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -73,6 +73,9 @@ static int temp_to_code(struct exynos_tmu_data *data, u8 temp)
> struct exynos_tmu_platform_data *pdata = data->pdata;
> int temp_code;
>
> + if (pdata->cal_mode == HW_MODE)
> + return temp;
> +
> if (data->soc == SOC_ARCH_EXYNOS4210)
> /* temp should range between 25 and 125 */
> if (temp < 25 || temp > 125) {
> @@ -107,6 +110,9 @@ static int code_to_temp(struct exynos_tmu_data *data, u8 temp_code)
> struct exynos_tmu_platform_data *pdata = data->pdata;
> int temp;
>
> + if (pdata->cal_mode == HW_MODE)
> + return temp_code;
> +
> if (data->soc == SOC_ARCH_EXYNOS4210)
> /* temp_code should range between 75 and 175 */
> if (temp_code < 75 || temp_code > 175) {
> @@ -155,6 +161,9 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
> if (TMU_SUPPORTS(pdata, TRIM_RELOAD))
> __raw_writel(1, data->base + reg->triminfo_ctrl);
>
> + if (pdata->cal_mode == HW_MODE)
> + goto skip_calib_data;
> +
> /* Save trimming info in order to perform calibration */
> if (data->soc == SOC_ARCH_EXYNOS5440) {
> /*
> @@ -190,6 +199,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
> (pdata->efuse_value >> reg->triminfo_85_shift) &
> EXYNOS_TMU_TEMP_MASK;
>
> +skip_calib_data:
> if (pdata->max_trigger_level > MAX_THRESHOLD_LEVS) {
> dev_err(&pdev->dev, "Invalid max trigger level\n");
> goto out;
> @@ -297,7 +307,7 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on)
> struct exynos_tmu_data *data = platform_get_drvdata(pdev);
> struct exynos_tmu_platform_data *pdata = data->pdata;
> const struct exynos_tmu_registers *reg = pdata->registers;
> - unsigned int con, interrupt_en;
> + unsigned int con, interrupt_en, cal_val;
>
> mutex_lock(&data->lock);
> clk_enable(data->clk);
> @@ -320,6 +330,27 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on)
> con |= (pdata->noise_cancel_mode << reg->therm_trip_mode_shift);
> }
>
> + if (pdata->cal_mode == HW_MODE) {
> + con &= ~(reg->calib_mode_mask << reg->calib_mode_shift);
> + cal_val = 0;
> + switch (pdata->cal_type) {
> + case TYPE_TWO_POINT_TRIMMING:
> + cal_val = 3;
> + break;
> + case TYPE_ONE_POINT_TRIMMING_85:
> + cal_val = 2;
> + break;
> + case TYPE_ONE_POINT_TRIMMING_25:
> + cal_val = 1;
> + break;
> + case TYPE_NONE:
> + break;
> + default:
> + dev_err(&pdev->dev, "Invalid calibration type, using none\n");
> + }
> + con |= cal_val << reg->calib_mode_shift;
> + }
> +
> if (on) {
> con |= (1 << reg->core_en_shift);
> interrupt_en =
> diff --git a/drivers/thermal/samsung/exynos_tmu.h b/drivers/thermal/samsung/exynos_tmu.h
> index 25c48d4..b364c9e 100644
> --- a/drivers/thermal/samsung/exynos_tmu.h
> +++ b/drivers/thermal/samsung/exynos_tmu.h
> @@ -28,6 +28,8 @@
>
> enum calibration_type {
> TYPE_ONE_POINT_TRIMMING,
> + TYPE_ONE_POINT_TRIMMING_25,
> + TYPE_ONE_POINT_TRIMMING_85,
> TYPE_TWO_POINT_TRIMMING,
> TYPE_NONE,
> };
> @@ -90,6 +92,10 @@ enum soc_type {
> * @buf_slope_sel_shift: shift bits of amplifier gain value in tmu_ctrl
> register.
> * @buf_slope_sel_mask: mask bits of amplifier gain value in tmu_ctrl register.
> + * @calib_mode_shift: shift bits of calibration mode value in tmu_ctrl
> + register.
> + * @calib_mode_mask: mask bits of calibration mode value in tmu_ctrl
> + register.
> * @therm_trip_tq_en_shift: shift bits of thermal trip enable by TQ pin in
> tmu_ctrl register.
> * @core_en_shift: shift bits of TMU core enable bit in tmu_ctrl register.
> @@ -151,6 +157,8 @@ struct exynos_tmu_registers {
> u32 therm_trip_en_shift;
> u32 buf_slope_sel_shift;
> u32 buf_slope_sel_mask;
> + u32 calib_mode_shift;
> + u32 calib_mode_mask;
> u32 therm_trip_tq_en_shift;
> u32 core_en_shift;
>
> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
> index 5952915..9002499 100644
> --- a/drivers/thermal/samsung/exynos_tmu_data.c
> +++ b/drivers/thermal/samsung/exynos_tmu_data.c
> @@ -189,6 +189,8 @@ static const struct exynos_tmu_registers exynos5440_tmu_registers = {
> .therm_trip_en_shift = EXYNOS_TMU_THERM_TRIP_EN_SHIFT,
> .buf_slope_sel_shift = EXYNOS_TMU_BUF_SLOPE_SEL_SHIFT,
> .buf_slope_sel_mask = EXYNOS_TMU_BUF_SLOPE_SEL_MASK,
> + .calib_mode_shift = EXYNOS_TMU_CALIB_MODE_SHIFT,
> + .calib_mode_mask = EXYNOS_TMU_CALIB_MODE_MASK,
> .core_en_shift = EXYNOS_TMU_CORE_EN_SHIFT,
> .tmu_status = EXYNOS5440_TMU_S0_7_STATUS,
> .tmu_cur_temp = EXYNOS5440_TMU_S0_7_TEMP,
> diff --git a/drivers/thermal/samsung/exynos_tmu_data.h b/drivers/thermal/samsung/exynos_tmu_data.h
> index 43ce5fb..dc7feb5 100644
> --- a/drivers/thermal/samsung/exynos_tmu_data.h
> +++ b/drivers/thermal/samsung/exynos_tmu_data.h
> @@ -75,6 +75,8 @@
> #define EXYNOS_TMU_TRIP_MODE_SHIFT 13
> #define EXYNOS_TMU_TRIP_MODE_MASK 0x7
> #define EXYNOS_TMU_THERM_TRIP_EN_SHIFT 12
> +#define EXYNOS_TMU_CALIB_MODE_SHIFT 4
> +#define EXYNOS_TMU_CALIB_MODE_MASK 0x3
>
> #define EXYNOS_TMU_INTEN_RISE0_SHIFT 0
> #define EXYNOS_TMU_INTEN_RISE1_SHIFT 4
>

--
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

Attachment: signature.asc
Description: OpenPGP digital signature

Next message: Mark Salter: "Re: linux-next: problem trying to fetch the c6x tree"
Previous message: Roger Quadros: "Re: [PATCH V2] USB: initialize or shutdown PHY when add or removehost controller"
In reply to: Amit Daniel Kachhap: "[PATCH RESEND V7 25/30] thermal: exynos: Add hardware mode thermal calibration support"
Next in thread: Amit Daniel Kachhap: "[PATCH V7 27/30] ARM: dts: thermal: exynos: Add documentation for Exynos SoC thermal bindings"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]