Re: [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090

[Stephen Warren]

On 06/25/2013 09:39 AM, Linus Walleij wrote:
> On Tue, Jun 25, 2013 at 3:50 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
>> On 25/06/13 14:32, Linus Walleij wrote:
> 
>>> Patches adding it back in with SI measures will be welcomed!
>>
>> Okay.
>>
>> So the most descriptive documentation I can find for the slew rate in
>> the TZ1090 pin config hardware is basically:
>>
>> 0: slow (half frequency)
>> 1: fast
>>
>> Sounds like this pretty much precludes it from having a generic DT
>> binding unless it can be mapped to some physical value, so I'll add a
>> tz1090,slew-rate and use PIN_CONFIG_END+1 instead of PIN_CONFIG_SLEW_RATE.
> 
> Okay... ut the Nomadik pin controller incidentally have a
> similar definition: NMK_GPIO_LOWEMI. By slashing the
> slew rate in half the EMI is of course reduced so that was
> another name for the same thing.
> 
> Maybe this is something that should just be boolean?
> 
> slewrate-reduced-slope;

Tegra has, IIRC, 4 different slew rates. I'm not sure that a
Boolean/dual-state value would be appropriate here; it'd be limited to
supporting some arbitrary cases rather than being something generic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/