Re: [PATCH V2] regulator: 88pm800: add regulator driver for 88pm800

[Chao Xie]

On Tue, Jun 25, 2013 at 5:12 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Jun 25, 2013 at 10:13:38AM +0800, Chao Xie wrote:
>> On Mon, Jun 24, 2013 at 6:14 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
>> > If you really need to have platform data for all the regulators then
>> > just embed the array inside the platform data so there's no possibility
>> > of any confusion.
>
>> Some regulators will not be exported to kernel depending on boards which are
>> for special usage. So i do not use a array inside the platform data.
>
> Remember that the regulator API won't do anything except read from a
> regulator unless it's got constraints saying it's OK to do so.  Are you
> saying that even reading the hardware state is a problem?
The regulator driver does not only work for 88pm805 but also for the
next lite version 88pm822.
88pm822 only have 14 LDOes. So i defined array of points in pdata.
When user define pdata for 88pm805, it can fill all 19 LDOes, while
for 88pm822, it only fill 14 LDOes, and set
others to be NULL, and do not need fill some dummy data into the left 5 LDOes.
The 88pm822 is just tape out, and we are debugging at it. So the
detection of 88pm822 is not added to this driver yet.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/