Re: [PATCH] arch/arc: angel4.dts - add description for "arc_emac"

[Vineet Gupta]

On 06/26/2013 03:07 PM, Alexey Brodkin wrote:
> With this patch we introduce DT "arc_emac" description for ARCangel4.
> Description is based on info/example in
> "Documentation/devicetree/bindings/net/arc_emac.txt".
>
> Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Cc: Francois Romieu <romieu@xxxxxxxxxxxxx>
> Cc: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> Cc: Mischa Jonker <mjonker@xxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: devicetree-discuss@xxxxxxxxxxxxxxxx
> Cc: Florian Fainelli <florian@xxxxxxxxxxx>
> ---
>  arch/arc/boot/dts/angel4.dts |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arc/boot/dts/angel4.dts b/arch/arc/boot/dts/angel4.dts
> index bae4f93..4fb2d6f 100644
> --- a/arch/arc/boot/dts/angel4.dts
> +++ b/arch/arc/boot/dts/angel4.dts
> @@ -51,5 +51,21 @@
>  			current-speed = <115200>;
>  			status = "okay";
>  		};
> +
> +		ethernet@c0fc2000 {
> +			compatible = "snps,arc-emac";
> +			reg = <0xc0fc2000 0x3c>;
> +			interrupts = <6>;
> +			mac-address = [ 00 11 22 33 44 55 ];
> +			clock-frequency = <80000000>;
> +			max-speed = <100>;
> +			phy = <&phy0>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			phy0: ethernet-phy@0 {
> +				reg = <1>;
> +			};
> +		};
>  	};
>  };

This looks good - for completeness sake, can you also send a patch to remove
legacy hardcodings for irq/mem-map from arch/arc/plat-arcfpga/include/*

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/