Re: [PATCH v3 1/2] uio: Use of_match_ptr() macro in uio_pdrv_genirq.c
From: Michal Simek
Date: Wed Jun 26 2013 - 08:50:28 EST
On 06/26/2013 01:13 PM, Sachin Kamat wrote:
> On 26 June 2013 16:34, Michal Simek <monstr@xxxxxxxxx> wrote:
>> On 06/26/2013 12:51 PM, Sachin Kamat wrote:
>>> On 26 June 2013 15:51, Michal Simek <monstr@xxxxxxxxx> wrote:
>>>> On 06/26/2013 12:00 PM, Sachin Kamat wrote:
>>>>> On 26 June 2013 15:22, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>>>>>> This eliminates having an #ifdef returning NULL for the case
>>>>>> when OF is disabled.
>>>>>>
>>>>>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>>>>>
>>>>> I have already submitted a similar patch for doing this:
>>>>> https://lkml.org/lkml/2013/3/14/169
>>>>
>>>> Ok. I don't care about it.
>>>> Greg: Can you please add any of this patch to your char-misc tree?
>>>>
>>>> For Sachin patch.
>>>> Acked-by: Michal Simek <monstr@xxxxxxxxx>
>>>
>>> Thanks Michal. Since Hans wasn't active the patch has been pending
>>> since some time.
>>> The latest rebased version has been posted [1] for Greg to apply.
>>>
>>> [1] https://lkml.org/lkml/2013/6/25/7
>>
>>
>> Yeah. As I said I really don't care which version will be applied.
>> It is just necessary to have progress on this.
>>
>> Here is the first version I have sent
>> http://lkml.org/lkml/2013/5/23/311
>>
>> btw: do you agree about removing that uio_pdrv because
>> all functionality is already in uio_pdrv_genirq driver
>> and make no sense to have two drivers for the same thing?
>
> Sorry, I have'nt seen much of this code other than the obvious
> cleanup for which I had sent the patch.
ok. Fair enough.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Attachment:
signature.asc
Description: OpenPGP digital signature