Re: [PATCH 2/4] x86: efi: break efi_lookup_mapped_addr out togeneric code

From: Leif Lindholm
Date: Wed Jun 26 2013 - 10:11:43 EST


On Wed, Jun 26, 2013 at 02:32:17PM +0100, Matt Fleming wrote:
> On Tue, 25 Jun, at 07:11:01PM, Leif Lindholm wrote:
> > efi_lookup_mapped_addr is a handy helper function for translating
> > a physical address to the corresponding virtual one by scanning
> > through memmap.map.
> >
> > This patch breaks it out into a new file for use elsewhere.
> >
> > Signed-off-by: Leif Lindholm <leif.lindholm@xxxxxxxxxx>
> > ---
> > arch/x86/platform/efi/efi.c | 28 ----------------------------
> > drivers/firmware/efi/Makefile | 2 +-
> > drivers/firmware/efi/efi-helper.c | 33 +++++++++++++++++++++++++++++++++
> > 3 files changed, 34 insertions(+), 29 deletions(-)
> > create mode 100644 drivers/firmware/efi/efi-helper.c
>
> I'm not sure this function needs its own file. drivers/firmware/efi/efi.c
> is a suitable place for this.

Sure.
Would you be happy for me to start moving the other things mentioned
(config table parsing, common debug printout, global structs) in there too?

/
Leif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/